summaryrefslogtreecommitdiff
path: root/firmware/drivers/lcd-16bit.c
diff options
context:
space:
mode:
authorDave Chapman <dave@dchapman.com>2007-05-15 14:26:44 +0000
committerDave Chapman <dave@dchapman.com>2007-05-15 14:26:44 +0000
commite22b33ec72abbcc71df30a38328311dd68a178c7 (patch)
tree0818bcd82df7a5f252d391d04b70394696a9d659 /firmware/drivers/lcd-16bit.c
parent4bf27eccdd91c9999e1bcbfe6350193498e30e96 (diff)
downloadrockbox-e22b33ec72abbcc71df30a38328311dd68a178c7.zip
rockbox-e22b33ec72abbcc71df30a38328311dd68a178c7.tar.gz
rockbox-e22b33ec72abbcc71df30a38328311dd68a178c7.tar.bz2
rockbox-e22b33ec72abbcc71df30a38328311dd68a178c7.tar.xz
Gigabeat LCD driver cleanup: Revert the DMA optimisations to the gigabeat LCD driver - they are both buggy (the wrong background colour was often seen, e.g. in the USB screen after using a plugin) and significantly slower than the standard implementations (which use the ARM-optimised mem* functions) in lcd-16bit.c. lcd_clear_update was 4.5 times slower with DMA when a backdrop is in use, and 12 times slower with DMA when no backdrop is in use.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13392 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/drivers/lcd-16bit.c')
-rw-r--r--firmware/drivers/lcd-16bit.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/firmware/drivers/lcd-16bit.c b/firmware/drivers/lcd-16bit.c
index 67736dd..0a3d193 100644
--- a/firmware/drivers/lcd-16bit.c
+++ b/firmware/drivers/lcd-16bit.c
@@ -105,24 +105,20 @@ int lcd_get_drawmode(void)
return drawmode;
}
-#if !defined(TOSHIBA_GIGABEAT_F) || defined(SIMULATOR)
void lcd_set_foreground(unsigned color)
{
fg_pattern = color;
}
-#endif
unsigned lcd_get_foreground(void)
{
return fg_pattern;
}
-#if !defined(TOSHIBA_GIGABEAT_F) || defined(SIMULATOR)
void lcd_set_background(unsigned color)
{
bg_pattern = color;
}
-#endif
unsigned lcd_get_background(void)
{
@@ -221,7 +217,6 @@ void lcd_set_backdrop(fb_data* backdrop)
lcd_backdrop_offset = 0;
lcd_fastpixelfuncs = lcd_fastpixelfuncs_bgcolor;
}
- lcd_device_prepare_backdrop(backdrop);
}
fb_data* lcd_get_backdrop(void)
@@ -232,7 +227,6 @@ fb_data* lcd_get_backdrop(void)
/*** drawing functions ***/
/* Clear the whole display */
-#if !defined(TOSHIBA_GIGABEAT_F) || defined(SIMULATOR)
void lcd_clear_display(void)
{
fb_data *dst = LCDADDR(0, 0);
@@ -250,7 +244,6 @@ void lcd_clear_display(void)
}
scrolling_lines = 0;
}
-#endif
/* Set a single pixel */
void lcd_drawpixel(int x, int y)