summaryrefslogtreecommitdiff
path: root/rbutil/rbutilqt/base/encoderlame.cpp
diff options
context:
space:
mode:
authorDominik Riebeling <Dominik.Riebeling@gmail.com>2012-01-11 20:18:26 +0100
committerDominik Riebeling <Dominik.Riebeling@gmail.com>2012-01-14 12:14:49 +0100
commit42fa2a8d0f6891f2d64eeb4de1920655f784e79a (patch)
tree45ca0d5b5f162aa705b5376347171dcc59f08a41 /rbutil/rbutilqt/base/encoderlame.cpp
parentb17bdb93493eec82fa60f5e0f008aa292aed6f10 (diff)
downloadrockbox-42fa2a8d0f6891f2d64eeb4de1920655f784e79a.zip
rockbox-42fa2a8d0f6891f2d64eeb4de1920655f784e79a.tar.gz
rockbox-42fa2a8d0f6891f2d64eeb4de1920655f784e79a.tar.bz2
rockbox-42fa2a8d0f6891f2d64eeb4de1920655f784e79a.tar.xz
Improve error handling and logging.
- Fix a warning - Log an error if the file to encode cannot be read. - Adjust some log strings.
Diffstat (limited to 'rbutil/rbutilqt/base/encoderlame.cpp')
-rw-r--r--rbutil/rbutilqt/base/encoderlame.cpp9
1 files changed, 6 insertions, 3 deletions
diff --git a/rbutil/rbutilqt/base/encoderlame.cpp b/rbutil/rbutilqt/base/encoderlame.cpp
index d85453c..52937e9 100644
--- a/rbutil/rbutilqt/base/encoderlame.cpp
+++ b/rbutil/rbutilqt/base/encoderlame.cpp
@@ -84,7 +84,7 @@ bool EncoderLame::start()
bool EncoderLame::encode(QString input,QString output)
{
- qDebug() << "[EncoderLame] Encoding" << input;
+ qDebug() << "[EncoderLame] Encoding" << QDir::cleanPath(input);
if(!m_symbolsResolved) {
qDebug() << "[EncoderLame] Symbols not successfully resolved, cannot run!";
return false;
@@ -113,11 +113,14 @@ bool EncoderLame::encode(QString input,QString output)
m_lame_set_scale(gfp, 1.0); // scale input volume
m_lame_set_mode(gfp, MONO); // mono output mode
m_lame_set_VBR(gfp, vbr_default); // enable default VBR mode
- m_lame_set_VBR_quality(gfp, 9.999); // VBR quality
+ m_lame_set_VBR_quality(gfp, 9.999f); // VBR quality
m_lame_set_VBR_max_bitrate_kbps(gfp, 64); // maximum bitrate 64kbps
m_lame_set_bWriteVbrTag(gfp, 0); // disable LAME tag.
- fin.open(QIODevice::ReadOnly);
+ if(!fin.open(QIODevice::ReadOnly)) {
+ qDebug() << "[EncoderLame] Could not open input file" << input;
+ return false;
+ }
// read RIFF header
fin.read((char*)header, 12);