summaryrefslogtreecommitdiff
path: root/apps/gui/gwps-common.c (follow)
Commit message (Collapse)AuthorAge
* Start of some apps/ and wps cleanup work... Move everything related to the ↵Jonathan Gordon2009-07-27
| | | | | | | | | actual drawing of the wps into apps/gui/wps_engine, things related to the actual screen are in apps/gui/music_screen.c (names are temporary unless noone comes up with anything better) No real code changes. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22062 a1c6a512-1295-4272-9138-f99709370657
* more cuesheet cleanup. pass the cuesheet into cue functions so they dont ↵Jonathan Gordon2009-07-24
| | | | | | have to call audio_current_track() git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22020 a1c6a512-1295-4272-9138-f99709370657
* Fix possible null pointer dereference in cuesheet handling. Causes problems ↵Magnus Holmgren2009-07-23
| | | | | | in the simulator. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22015 a1c6a512-1295-4272-9138-f99709370657
* this file also...Jonathan Gordon2009-07-23
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22013 a1c6a512-1295-4272-9138-f99709370657
* rework cuesheet support:Jonathan Gordon2009-07-20
| | | | | | | | | | | swcodec: search for a .cue during buffering (with the possibility of adding embedded cuesheets later) hwcodec: search for a .cue when the id3 info for the current track is requested for the first time (disk should be spining so non issue) major beenfit from this is simplofy cuesheet handling code a bit... if mp3entry.cuesheet != NULL then there is a valid cuesheet.. no need to worry about if its enabled and preloaded. There is the possibility of putting the next/prev subtrack handling inside the playback code (as well as the id3 updating stuff (see FS#9789 for more info), but thats probably not a good idea. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21978 a1c6a512-1295-4272-9138-f99709370657
* FS#10080Nils Wallménius2009-07-14
| | | | | | | | | | * Move strncpy() from core to the pluginlib * Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins * Drop strncpy() from the codec api as no codec used it * Bump codec and plugin api versions git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
* Merge the "Replaygain Off" option into the replaygain type; eliminate the ↵Alexander Levin2009-06-20
| | | | | | "On/Off" setting (FS#10356). All WPS tags should work as before. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21414 a1c6a512-1295-4272-9138-f99709370657
* get repeat/hold actions working on the touchscreen WPS. prepending an action ↵Jonathan Gordon2009-05-17
| | | | | | with & means that this will only get triggered if you hold down the area. cabbie WPS updated so the fwd/rwd icons will do that when held or skip fwd/back if just pressed. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20974 a1c6a512-1295-4272-9138-f99709370657
* New 'clock present' WPS tag: The tag checks for the presence of the clock ↵Marianne Arnold2009-05-16
| | | | | | hardware and can be used unconditionally (returning a 'c') or in a conditional. You can specify what to display if a target has the clock (the true case) and an alternative for targets without. This can be useful for e.g. the greyscale 160x128 WPSs or the Archos ones which work on players with and without the hardware. - Add the new tag to the WPS tag description in the manual. Change the headline to the less technical 'Time and Date' as per the discussion in IRC. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20961 a1c6a512-1295-4272-9138-f99709370657
* beginings of a working touchscreen interface for the WPS. 2 new tags:Jonathan Gordon2009-04-20
| | | | | | | | | | | %T|x|y|width|height|action| <- setup a region (relative to the current viewport) where if pressed the "action" will be done (currently play/stop/prev/next/menu/browse work, suggestions for others to add and better names welcome) %Tl<timeout> <- used as a conditional to say if the touchscreen was touched in the last <timeout>, use this to enable/disable button viewports or something... same syntax as other timeout tags cabbiev2 for the mr500 has been modified to demonstrate the new tags. press the pause/play button to pause playback. press the rockbox logo to get back to the menu. pretty icons needed to make this more usable :) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20753 a1c6a512-1295-4272-9138-f99709370657
* Fix caption backlight.Thomas Martitz2009-04-14
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20708 a1c6a512-1295-4272-9138-f99709370657
* FS9795 - some playback cleanup. Jonathan Gordon2009-04-06
| | | | | | | | | | | * Use events to notify things when the track has changed instead of the nasty has_track_changed() * Event for when the mp3entry for the next track is avilable (which allows alot more tags to be static which means less redrawing in the WPS) * virtually guarentee that the mp3entry sturct returned by audio_current/next_track() is going to be valid for the duration of the current track. The only time it wont be now is during the time between the codec finishing the previous track and the next track actually starting (~2s), but this is not an issue as long as it is called again when the TRACK_CHANGED event happens (or just use the pointer that gives) It is still possible to confuse the WPS with the next tracks id3 info being displayed but this should fix itself up faster than it used to (and be harder to do) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20633 a1c6a512-1295-4272-9138-f99709370657
* Fix potential NULL pointer access.Jens Arnold2009-03-29
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20566 a1c6a512-1295-4272-9138-f99709370657
* Fix red, and use gui_wps_display() for restoration.Thomas Martitz2009-03-23
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20485 a1c6a512-1295-4272-9138-f99709370657
* Another wps rework:Thomas Martitz2009-03-23
| | | | | | | | | | | *rename gui_wps_refresh() to gui_wps_redraw() and update() to gui_wps_update() to better describe what they do *Clear things up and differentiate better between gui_wps_redraw()/gui_wps_display()/gui_wps_update() (it wasn't so what they're supposed to do before) *cleanup gui_wps_display() and gui_wps_update() quite a bit *Remove unused/unneeded code, do some pointer copying to save binsize, and code cleanup at several places Visible changes should be small git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20483 a1c6a512-1295-4272-9138-f99709370657
* Fix up statusbar drawing in the wps a bit, fixing most, if not all, ↵Thomas Martitz2009-03-20
| | | | | | | | | | | | (re-)draw issues. a) remove the temporary work around in gui_wps_display b) let the wps-statusbars redraw if it's masked (i.e. WPS_REFRESH_ALL or WPS_REFRESH_STATUSBAR) c) fix a bug of mine, I attached re-fixing the bars to the wrong event d) unify the decision whether to draw bars at all e) some other style/code minor cleanups git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20400 a1c6a512-1295-4272-9138-f99709370657
* Move play_hop() to gwps.c and make it static. It's the only file that calls it.Thomas Martitz2009-03-12
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20306 a1c6a512-1295-4272-9138-f99709370657
* Cleanup play_hop() slightly and remove redundant/uneeded checks, reclaim a ↵Thomas Martitz2009-02-24
| | | | | | tiny bit of binsize git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20097 a1c6a512-1295-4272-9138-f99709370657
* Move parts into the if, as they're unused outside of itThomas Martitz2009-02-16
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20016 a1c6a512-1295-4272-9138-f99709370657
* FS#9904 - Fix for FS#9894 - Position of the progress bar is not updated ↵Thomas Martitz2009-02-16
| | | | | | after the font is changed (with small changes by me) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20015 a1c6a512-1295-4272-9138-f99709370657
* fix redJonathan Gordon2009-02-04
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19918 a1c6a512-1295-4272-9138-f99709370657
* Temp fix for the statusbar disappearing for a fraction of a second when the ↵Jonathan Gordon2009-02-04
| | | | | | WPS is first opened git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19917 a1c6a512-1295-4272-9138-f99709370657
* Statusbar handling fixes. Jonathan Gordon2009-02-01
| | | | | | | | | | | Fixes FS#9845 - %we/%wd wasnt working WPS no longer resets the viewportmanger more than needed (was doing it twice/draw before) screens can now enable/disable the statusbar easily ignoring the setting instead of needing special handling (fix for the radio screen coming soon) minor glitch introduced in this commit... the statusbar in the WPS might disappear for a fraction of a second when it is entered, I need to track this down... git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19894 a1c6a512-1295-4272-9138-f99709370657
* FS#9638 - temp_cue is unused and wasting memory.Bertrik Sikken2009-01-31
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19890 a1c6a512-1295-4272-9138-f99709370657
* fix the statusbar on the archos player... a more proper fix is probably to ↵Jonathan Gordon2009-01-12
| | | | | | surround global_Settings.statusbar with #ifdef HAVE_LCD_BITMAP... maybe.. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19753 a1c6a512-1295-4272-9138-f99709370657
* fix FS#9772 - the statusbars were not working correclty on multi screen ↵Jonathan Gordon2009-01-10
| | | | | | targets in the WPS git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19742 a1c6a512-1295-4272-9138-f99709370657
* remove some useless/unused stuff from gwps.cJonathan Gordon2009-01-07
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19705 a1c6a512-1295-4272-9138-f99709370657
* a few more button/statusbar fixes...Jonathan Gordon2009-01-03
| | | | | | | | | | | * hopefully fix the last of the plugins which dont handle the enw SYS event. * fix FS#9750 - WPS's which dont specify (or force the wps on) wernt showing the statusbar at all * lamp, battery_bench, *_flash button handling fixes * plugins using the core menu code will again show the statusbar git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19656 a1c6a512-1295-4272-9138-f99709370657
* Reorder of user_settings, cleaned out some unused settings grouped settings ↵Nils Wallménius2009-01-03
| | | | | | depending on the same preprocessor defines together a bit more to make it more readable, updated some comments. Plugin api bump and the wps token for 12/24 hour clock setting is now excluded for non rtc targets git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19655 a1c6a512-1295-4272-9138-f99709370657
* Decouple the statusbar drawing from the rest of the screen drawing. it is ↵Jonathan Gordon2008-12-31
| | | | | | | | | | | | not drawn roughly 4x per second automatically. viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.) All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false). This commit also includes some menu/list viewport cleanups from kugel in FS#9603 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
* Make some more constants involved in right shifts unsigned to get rid of ↵Jens Arnold2008-12-12
| | | | | | __ashrsi3 in the Player's core as well, saving some binsize. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19409 a1c6a512-1295-4272-9138-f99709370657
* Apply FS#9368 : add generic settings tag to WPS.Antoine Cellerier2008-12-07
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19357 a1c6a512-1295-4272-9138-f99709370657
* FS#9557 - fix the %mv and %t timeout so its intrepreted correctlyJonathan Gordon2008-11-22
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19177 a1c6a512-1295-4272-9138-f99709370657
* revert the previous commit to find a nice way to fix the yellow...Jonathan Gordon2008-11-16
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19111 a1c6a512-1295-4272-9138-f99709370657
* FS#9477 - new WPS tag (%mo) which lets the WPS have different "modes" which ↵Jonathan Gordon2008-11-16
| | | | | | | | | | | | | are changed with the usual "back to browser" button (This button is ONLY stolen if the WPS you use uses this tag. an example use: %?mo<one|two|three> meaning that when the WPS is first opened "one" will be displayed, pressing select will change it to showing two, pressing it again will show three, and once more will go back to showing one. The text there could be any wps tags (conditional viewports for example...) There is no real limit on the amount of modes, but remember that if you create a WPS which uses this tag more than once that every use HAS to have the same amount of choices or bad things will happen. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19110 a1c6a512-1295-4272-9138-f99709370657
* * Make %t stricter by aborting if a value is not given.Jonathan Gordon2008-10-11
| | | | | | | | * Move the default value for %mv back into wps_parser.c where it belongs * Add the debug line for the %mv tag git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18773 a1c6a512-1295-4272-9138-f99709370657
* update the %mv wps tag to let you specify how long it should wait after ↵Jonathan Gordon2008-10-11
| | | | | | | | | being released to go back to false. e.g %mv2 will stay true for 2 seconds or %mv3.5 is 3.5 seconds (same as the %t syntax)... if no number is specified it defaults to 1 second git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18769 a1c6a512-1295-4272-9138-f99709370657
* change the %mv timeout to 1s which works better, also change the string to ↵Jonathan Gordon2008-10-09
| | | | | | show "v" instead of .:| if its not used as a conditional git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18759 a1c6a512-1295-4272-9138-f99709370657
* FS#9460 - Add a tag %mv which can be used to check if the volume button is ↵Jonathan Gordon2008-10-09
| | | | | | being pressed (e.g %?mv<yes|no> ). It will stay true after its released for a little over half a second (not configurable unless someone comes up with a nice way to add a parameter to the tag? 1s is too long and .5s is too short... git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18752 a1c6a512-1295-4272-9138-f99709370657
* Clean up use of snprintf where strncpy if suited, avoid useless copying of ↵Nils Wallménius2008-09-24
| | | | | | constant strings for wps token evaluator, minor const police too. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18625 a1c6a512-1295-4272-9138-f99709370657
* A few comment updates and trailing spaces removals.Nicolas Pennequin2008-09-06
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18433 a1c6a512-1295-4272-9138-f99709370657
* Make %mm 0-based again (as described in CustomWPS), and change %cf accordingly.Nicolas Pennequin2008-09-04
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18421 a1c6a512-1295-4272-9138-f99709370657
* Fix the bug reported in FS#9350: the WPS would crash on %mm or %cf if they ↵Nicolas Pennequin2008-09-04
| | | | | | weren't in conditionals. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18420 a1c6a512-1295-4272-9138-f99709370657
* Skip length: restore the ability to skip by just a few secondsStéphane Doyon2008-08-18
| | | | | | | | (which was the point of that feature). See r18041. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18310 a1c6a512-1295-4272-9138-f99709370657
* FS#9281 Rename of splash functions.Nils Wallménius2008-08-15
| | | | | | | | | | | | | | | | | | | | * Remove gui_splash() * Rename gui_syncsplash() to splashf() and remove its voice capabilities. * Rename the internal splash() to splash_internal() and introduce an externally visible splash() that handles simple splashing without printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, "foo"); if a LANG_* id is passed it will be voiced. * Adjust all places that called gui_syncsplash() to use the correct variant from above. * Export both new functions to plugins and adjust places calling rb->splash() to use the correct variant so that we now have naming consistency between the core and plugins. * Fix one latent bug that would cause my sim to crash with the above changes and correct P2STR and P2ID macros, thanks to pondlife. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
* Fix FS#8689 (the peak meter does not work during a playing after a recording ↵Bertrik Sikken2008-08-11
| | | | | | not followed by a reboot) by applying the patch from FS#9227. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18249 a1c6a512-1295-4272-9138-f99709370657
* Rename and rework the "Study Mode" menu into the "Skip Length" setting. ↵Thom Johansen2008-07-14
| | | | | | Update manual. Bump plugin API thanks to having changed global_settings. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18041 a1c6a512-1295-4272-9138-f99709370657
* Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg2008-06-28
| | | | | | | | | later. We still need to hunt down snippets used that are not. 1324 modified files... http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
* implement smooth seeking acceleration for audio playback and mpegplayerMarcoen Hirschberg2008-06-28
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17843 a1c6a512-1295-4272-9138-f99709370657
* FS#9051 - remove LCD margins... use viewports if you need them...Jonathan Gordon2008-06-23
| | | | | | | | | | | NOTE to WPS people.... %m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored. Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected. Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657