summaryrefslogtreecommitdiff
path: root/apps/gui/gwps.c (follow)
Commit message (Collapse)AuthorAge
* Start of some apps/ and wps cleanup work... Move everything related to the ↵Jonathan Gordon2009-07-27
| | | | | | | | | actual drawing of the wps into apps/gui/wps_engine, things related to the actual screen are in apps/gui/music_screen.c (names are temporary unless noone comes up with anything better) No real code changes. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22062 a1c6a512-1295-4272-9138-f99709370657
* more cuesheet cleanup. pass the cuesheet into cue functions so they dont ↵Jonathan Gordon2009-07-24
| | | | | | have to call audio_current_track() git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22020 a1c6a512-1295-4272-9138-f99709370657
* Commit part of FS#9873 - Utilise buttons for playlistingThomas Martitz2009-07-22
| | | | | | | It adds a shortcut (combo or button) to directly go from the wps to the playlist viewer. The combos could possibly be improved on some targets, but I tried to keep a tad bit of consistency (was hardly possible). I also added a corresponding touchscreen region and adapted cabbiev2. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22003 a1c6a512-1295-4272-9138-f99709370657
* rework cuesheet support:Jonathan Gordon2009-07-20
| | | | | | | | | | | swcodec: search for a .cue during buffering (with the possibility of adding embedded cuesheets later) hwcodec: search for a .cue when the id3 info for the current track is requested for the first time (disk should be spining so non issue) major beenfit from this is simplofy cuesheet handling code a bit... if mp3entry.cuesheet != NULL then there is a valid cuesheet.. no need to worry about if its enabled and preloaded. There is the possibility of putting the next/prev subtrack handling inside the playback code (as well as the id3 updating stuff (see FS#9789 for more info), but thats probably not a good idea. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21978 a1c6a512-1295-4272-9138-f99709370657
* Correct another small typo in a comment.Thomas Martitz2009-07-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21746 a1c6a512-1295-4272-9138-f99709370657
* Fix a typoAlexander Levin2009-07-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21741 a1c6a512-1295-4272-9138-f99709370657
* Fix a few comments in gwps.c.Thomas Martitz2009-07-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21740 a1c6a512-1295-4272-9138-f99709370657
* cleanup the remote+main statusbar handling a bit, and fix the bug where the ↵Jonathan Gordon2009-07-08
| | | | | | remote wps might reserve the space for the statusbar even if its disabled git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21709 a1c6a512-1295-4272-9138-f99709370657
* FS#10406 - split the statusbar setting into one for each display, and allow ↵Jonathan Gordon2009-07-05
| | | | | | the bar to be at the top or bottom of the display git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21665 a1c6a512-1295-4272-9138-f99709370657
* Fix the bug where the short-long fwd/back action would ffwd/rewind the next ↵Jonathan Gordon2009-07-03
| | | | | | folder (consult the manual if that makes no sense) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21619 a1c6a512-1295-4272-9138-f99709370657
* Restore the ACTION_REDRAW case as it was before r20661 (with a slight change ↵Marianne Arnold2009-06-18
| | | | | | as suggested by Thomas Martitz). Without it you could get trapped in the WPS on targets with software hold as disabling hold again did not work correctly. Also fix(ed) typos... git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21325 a1c6a512-1295-4272-9138-f99709370657
* Fix FS#10231. The gwps_leave_wps() call at powering down is completely ↵Thomas Martitz2009-05-24
| | | | | | unnecessary anyway as it's meant to prepare the displaying of the next screen, which isn't needed when there's no next screen. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21067 a1c6a512-1295-4272-9138-f99709370657
* Fix duplicate #includesBertrik Sikken2009-05-17
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20977 a1c6a512-1295-4272-9138-f99709370657
* get repeat/hold actions working on the touchscreen WPS. prepending an action ↵Jonathan Gordon2009-05-17
| | | | | | with & means that this will only get triggered if you hold down the area. cabbie WPS updated so the fwd/rwd icons will do that when held or skip fwd/back if just pressed. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20974 a1c6a512-1295-4272-9138-f99709370657
* allow the user to change the shuffle and repeat modes from the touchscreen, ↵Jonathan Gordon2009-05-15
| | | | | | update the mr500 default wps to show how to do it (hint, press the shuffle/rep icon) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20937 a1c6a512-1295-4272-9138-f99709370657
* Revert r20786 as it caused problems with alternating sublines (they need to ↵Thomas Martitz2009-04-27
| | | | | | be reset if gui_wps_refresh() wasn't called for some time, since the subline timeout gets confused). Also, it needs to be set to get the update, since do_full_update will be set to false after track change no matter if an update happened. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20812 a1c6a512-1295-4272-9138-f99709370657
* Setting do_full_update isn't actually needed, since the track changed event ↵Thomas Martitz2009-04-25
| | | | | | will set it if needed. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20786 a1c6a512-1295-4272-9138-f99709370657
* beginings of a working touchscreen interface for the WPS. 2 new tags:Jonathan Gordon2009-04-20
| | | | | | | | | | | %T|x|y|width|height|action| <- setup a region (relative to the current viewport) where if pressed the "action" will be done (currently play/stop/prev/next/menu/browse work, suggestions for others to add and better names welcome) %Tl<timeout> <- used as a conditional to say if the touchscreen was touched in the last <timeout>, use this to enable/disable button viewports or something... same syntax as other timeout tags cabbiev2 for the mr500 has been modified to demonstrate the new tags. press the pause/play button to pause playback. press the rockbox logo to get back to the menu. pretty icons needed to make this more usable :) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20753 a1c6a512-1295-4272-9138-f99709370657
* Fix caption backlight.Thomas Martitz2009-04-14
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20708 a1c6a512-1295-4272-9138-f99709370657
* Fix remote wps updating (again, FS#10121).Thomas Martitz2009-04-12
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20693 a1c6a512-1295-4272-9138-f99709370657
* FS#8523 - Disable WPS updating when the backlight is off.Thomas Martitz2009-04-09
| | | | | | | Disables WPS updating when the lcd is inactive (sleep or disabled, backlight doesn't count in), which prevents a good deal of code from running uselessly. According to tests, it can yield up to 1h more battery life in cases of heavy WPSes. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20666 a1c6a512-1295-4272-9138-f99709370657
* Forgot to add the call too gwps_fix_statusbars(), fixes yellow too.Thomas Martitz2009-04-08
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20662 a1c6a512-1295-4272-9138-f99709370657
* WPS update optimizations:Thomas Martitz2009-04-08
| | | | | | | | *) always initialize restore with true, and make the get_action timeout 1 tick if restore is true (which only happens at initially showing the wps), which makes the wps show up way faster (nearly instantly) *) reduce the number of full updates by removing update_track (full updates are initiated by the event now), rename partial_update to update. Now, full updates should really happen only on (re-)entering the wps or track change now. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20661 a1c6a512-1295-4272-9138-f99709370657
* FS9795 - some playback cleanup. Jonathan Gordon2009-04-06
| | | | | | | | | | | * Use events to notify things when the track has changed instead of the nasty has_track_changed() * Event for when the mp3entry for the next track is avilable (which allows alot more tags to be static which means less redrawing in the WPS) * virtually guarentee that the mp3entry sturct returned by audio_current/next_track() is going to be valid for the duration of the current track. The only time it wont be now is during the time between the codec finishing the previous track and the next track actually starting (~2s), but this is not an issue as long as it is called again when the TRACK_CHANGED event happens (or just use the pointer that gives) It is still possible to confuse the WPS with the next tracks id3 info being displayed but this should fix itself up faster than it used to (and be harder to do) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20633 a1c6a512-1295-4272-9138-f99709370657
* Drop the unnecessary checks since they are made by the callerAlexander Levin2009-04-05
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20632 a1c6a512-1295-4272-9138-f99709370657
* Fix hopping backwards if skip length is > 0 and we're near the end of the ↵Alexander Levin2009-04-05
| | | | | | track (less than skip length) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20631 a1c6a512-1295-4272-9138-f99709370657
* A few skip length and dir change fixes.Thomas Martitz2009-04-04
| | | | | | | | *) Fix 64bit sim for playhop. *) Revert to pre-skip length behavor for dir skipping (always have dirskipping, no matter of skip length), only prevent dir skipping if "prevent track skipping" is enabled *) small code unification with regards to track and dir skipping git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20618 a1c6a512-1295-4272-9138-f99709370657
* Fix the resume problems on hwcodec which were uncovered by r20483+r20485. ↵Jens Arnold2009-03-29
| | | | | | The timing problem was there before; checking for id3 availability as a criterion whether to exit the wps was plain wrong. Now it exits only if playback actually finished. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20568 a1c6a512-1295-4272-9138-f99709370657
* Fix hwcodec to actually check for prevent_skipThomas Martitz2009-03-27
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20554 a1c6a512-1295-4272-9138-f99709370657
* FS#10014 - Separate tracklocking out of skip length, skip length prevented ↵Thomas Martitz2009-03-27
| | | | | | to skip tracks. This is a seperate setting now. tracks can still change during normal playback (i.e. a song ends). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20553 a1c6a512-1295-4272-9138-f99709370657
* Fix red, and use gui_wps_display() for restoration.Thomas Martitz2009-03-23
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20485 a1c6a512-1295-4272-9138-f99709370657
* Another wps rework:Thomas Martitz2009-03-23
| | | | | | | | | | | *rename gui_wps_refresh() to gui_wps_redraw() and update() to gui_wps_update() to better describe what they do *Clear things up and differentiate better between gui_wps_redraw()/gui_wps_display()/gui_wps_update() (it wasn't so what they're supposed to do before) *cleanup gui_wps_display() and gui_wps_update() quite a bit *Remove unused/unneeded code, do some pointer copying to save binsize, and code cleanup at several places Visible changes should be small git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20483 a1c6a512-1295-4272-9138-f99709370657
* Fix up statusbar drawing in the wps a bit, fixing most, if not all, ↵Thomas Martitz2009-03-20
| | | | | | | | | | | | (re-)draw issues. a) remove the temporary work around in gui_wps_display b) let the wps-statusbars redraw if it's masked (i.e. WPS_REFRESH_ALL or WPS_REFRESH_STATUSBAR) c) fix a bug of mine, I attached re-fixing the bars to the wrong event d) unify the decision whether to draw bars at all e) some other style/code minor cleanups git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20400 a1c6a512-1295-4272-9138-f99709370657
* Put exiting the wps entirely into the hands of the wps (restoring backdrops ↵Thomas Martitz2009-03-19
| | | | | | and statusbars, stop scrolling). Remove the restoration code from root_menu, and add some gwps_leave_wps at every possible return/screen change. This also unifies exiting the wps code-wise. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20399 a1c6a512-1295-4272-9138-f99709370657
* Move gwps_leave_wps() a bit down, so that the menu-statusbars are showing in ↵Thomas Martitz2009-03-19
| | | | | | sync with the rest of the followin screen. It was shown noticeably earlier, particularly if the fade on stop is on. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20355 a1c6a512-1295-4272-9138-f99709370657
* Some style changes, move gwps_leave_wps a bit down; add a #define for ↵Thomas Martitz2009-03-17
| | | | | | restoration after 1 second and rename the one for instant restoration git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20330 a1c6a512-1295-4272-9138-f99709370657
* Some internal rework of the wps:Thomas Martitz2009-03-17
| | | | | | | a) Put duplicated code together. The restoration code into the existing restoration part of the main loop, the exiting code into a separate function b) Let the STATUSBAR_CHANGED event handle fixing the statusbar git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20329 a1c6a512-1295-4272-9138-f99709370657
* Move play_hop() to gwps.c and make it static. It's the only file that calls it.Thomas Martitz2009-03-12
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20306 a1c6a512-1295-4272-9138-f99709370657
* Accept a quick patch from Alexander Levin to neaten up the #defines and ↵Jonathan Gordon2009-02-01
| | | | | | comments from my earlier commit git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19897 a1c6a512-1295-4272-9138-f99709370657
* Statusbar handling fixes. Jonathan Gordon2009-02-01
| | | | | | | | | | | Fixes FS#9845 - %we/%wd wasnt working WPS no longer resets the viewportmanger more than needed (was doing it twice/draw before) screens can now enable/disable the statusbar easily ignoring the setting instead of needing special handling (fix for the radio screen coming soon) minor glitch introduced in this commit... the statusbar in the WPS might disappear for a fraction of a second when it is entered, I need to track this down... git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19894 a1c6a512-1295-4272-9138-f99709370657
* use the playback PLAYBACK_EVENT_TRACK_CHANGE instead of the WPS to keep ↵Jonathan Gordon2009-01-11
| | | | | | track of the current track (for follow playlist) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19747 a1c6a512-1295-4272-9138-f99709370657
* fix FS#9772 - the statusbars were not working correclty on multi screen ↵Jonathan Gordon2009-01-10
| | | | | | targets in the WPS git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19742 a1c6a512-1295-4272-9138-f99709370657
* revert part of r19705 which caused fS#9773Jonathan Gordon2009-01-09
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19732 a1c6a512-1295-4272-9138-f99709370657
* remove some useless/unused stuff from gwps.cJonathan Gordon2009-01-07
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19705 a1c6a512-1295-4272-9138-f99709370657
* redo how the statusbar updates are done. send the EVENT_GUI_ACTIONUPDATE ↵Jonathan Gordon2009-01-05
| | | | | | | | | | event every time get_action() is called. The event wont be as realiable (timewise) as before, but seems to work better This also fixes FS#9761. Also set the lcd font back to the ui font from the debug screens which use sysfont git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19681 a1c6a512-1295-4272-9138-f99709370657
* woops... fix the header and bump the plugin APIJonathan Gordon2009-01-02
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19636 a1c6a512-1295-4272-9138-f99709370657
* More SYS_FOURHERTZ handling fixes.. (FS#9740 FS#9741)Jonathan Gordon2009-01-02
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19635 a1c6a512-1295-4272-9138-f99709370657
* try again... BUTTON_NONE is not a sys event :pJonathan Gordon2009-01-01
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19631 a1c6a512-1295-4272-9138-f99709370657
* fis FS#9739 - yesterdays statusbar commits broke the WPS disk spindown handlingJonathan Gordon2009-01-01
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19630 a1c6a512-1295-4272-9138-f99709370657
* resize-on-load for bitmap files on 2bpp and color targetsAndrew Mahone2008-12-09
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19374 a1c6a512-1295-4272-9138-f99709370657
generated by cgit v1.1 at 2026-04-25 15:17:16 +0000