summaryrefslogtreecommitdiff
path: root/tools/checkwps (follow)
Commit message (Collapse)AuthorAge
* Fix path handling snafu for CheckWPS toolMichael Sevakis2017-01-16
| | | | | | | | | Somehow it got hooked to simulator file functions when it should be (and was) using raw OS functions. Credit: Frank Gevaerts Change-Id: Iac02fed1067830a432183632a047e00dfd03d3c2
* Rewrite filesystem code (WIP)Michael Sevakis2014-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: http://gerrit.rockbox.org/566 Reviewed-by: Michael Sevakis <jethead71@rockbox.org> Tested: Michael Sevakis <jethead71@rockbox.org>
* Fix up some more redMichael Sevakis2014-08-05
| | | | | | | find_first_set_bit() becomes a small inline on ARMv5+ and checkwps now gets made with -std=gnu99 (it eats all the GCCOPTS) like the rest of things. Change-Id: Ie6039b17fec057a3dcb0f453d8fd5efac984df89
* Fix various reds. Some includes needed fixup.Thomas Martitz2014-03-03
| | | | Change-Id: I4327740bae17054131feb917abdd58846c451988
* RaaA: Move directory related stuff from filesystem-unix.c into rbpaths.c.Thomas Martitz2014-02-23
| | | | | | | | Part of this change is to align sdlapp builds to other application targets in that the sim_* wrappers are not used anymore (except for sim_read/write). Path mangling is now done in rbpaths.c as well. Change-Id: I9726da73b50a83d9e1a1840288de16ec01ea029d
* fix checkwpsJonathan Gordon2013-02-12
| | | | Change-Id: Ie3bdfe18db6f8279f3575b253519fe4820649898
* checkwps: Do not error out on rwps for non-remote targets.Thomas Martitz2012-09-24
| | | | | | | This breaks themes on the theme site (that ship an rwps for remote targets) for non-remote targets. As rockbox just ignores the rwps checkwps now does the same. Change-Id: Id8c7833f0bd88d239dce87711456b94c93480a51
* checkwps: harden filename extension checking.Thomas Martitz2012-07-31
| | | | Change-Id: I91aaacaaff621cfbeef9572df60b339a00475aa9
* checkwps: Simplify expression.Thomas Martitz2012-07-31
| | | | Change-Id: I4d5cf82aa753074f81f25ae3d89a97ee607376e5
* Add include path to checkwps.make to fix build.Nils Wallménius2012-05-03
| | | | Change-Id: I3edddee9422255bf6d944f76c74686a256a8a852
* CheckWPS needs an include patch to /lib/rbcodec/dsp.Michael Sevakis2012-04-29
| | | | Change-Id: I7092be2be4b23137e011b2344d92b40fdcf1517e
* Partly undo 54e00c1: put include back to root.make and use SECONDEXPANSION.Thomas Martitz2012-03-26
| | | | Change-Id: If38507ed896f577ea30e2ddae3bac3f4b98cee59
* Fix sim/checkwps build failure.Thomas Martitz2012-03-26
| | | | Change-Id: Iefd533fe26495a29f8e79113b38748b504d94213
* Add missing include path.Nils Wallménius2012-03-18
| | | | Change-Id: Icc19a89286f34fa88d151c0212273013d7b14f40
* skin_engine: Reenable skin debugging in the sim (use --debugwps)Jonathan Gordon2012-03-15
| | | | Change-Id: I2881edda45cd3ea69f5284d93bc93c47bb63b3f2
* Integrate the warble tool in the regular build system.Frank Gevaerts2012-03-03
| | | | | | Only sdl app builds work properly for now. Change-Id: I7807d42f69b8577b401e48cdc63de71e54f49217
* checkwps/ypr0: Forgot new file.Thomas Martitz2012-02-11
| | | | Change-Id: I14d2f1c174c118ba44fbbd92051157e0f21db68f
* checkwps: Fix buildall.sh and some RaaA/ypr0 versions.Thomas Martitz2012-02-10
| | | | Change-Id: I5889743e94ed568c8f7dcc50de0b03b8421969f7
* fix checkwpsJonathan Gordon2011-11-21
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31040 a1c6a512-1295-4272-9138-f99709370657
* Use buflib for all skin engine allocations.Jonathan Gordon2011-11-15
| | | | | | | | Massive thanks to Michael Chicoine and other testers for finding the early bugs. This removes all skin memory limitations git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30991 a1c6a512-1295-4272-9138-f99709370657
* try again, this time without compile errorsJonathan Gordon2011-11-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30951 a1c6a512-1295-4272-9138-f99709370657
* Fix checkwpsJonathan Gordon2011-11-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30950 a1c6a512-1295-4272-9138-f99709370657
* Fix checkwps reds and non-touchscreen warnings.Thomas Martitz2011-10-17
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30774 a1c6a512-1295-4272-9138-f99709370657
* Fix the build errorsJonathan Gordon2011-09-24
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30590 a1c6a512-1295-4272-9138-f99709370657
* Fix a bug introduced with r28370 (feature check tag improvements) where ↵Jonathan Gordon2010-11-03
| | | | | | %Rp<foo> would fail to parse if the target had recording. Also enable debugging in the checkwps build line git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28473 a1c6a512-1295-4272-9138-f99709370657
* checkwps: properly zero the wps struct to avoid interesting issuesFrank Gevaerts2010-10-18
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28308 a1c6a512-1295-4272-9138-f99709370657
* try againJonathan Gordon2010-08-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27770 a1c6a512-1295-4272-9138-f99709370657
* fid red/yellow... does database really need to compile all of misc.c?Jonathan Gordon2010-08-10
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27769 a1c6a512-1295-4272-9138-f99709370657
* make -vvv display the parse tree in checkwps. Fix a potential bug in the ↵Jonathan Gordon2010-08-03
| | | | | | parser where recursive tags (the playlist viewier) would share params with its parant which meant bad things git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27677 a1c6a512-1295-4272-9138-f99709370657
* FS#11470 - new skin code, finally svn uses the new parser from the theme ↵Jonathan Gordon2010-07-29
| | | | | | editor. This means that a skin that passes the editor WILL pass svn and checkwps (unless the target runs out of skin buffer or something. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27613 a1c6a512-1295-4272-9138-f99709370657
* global tab->spaces is not clever with Makefiles!Jonathan Gordon2010-05-17
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26112 a1c6a512-1295-4272-9138-f99709370657
* fix yellow/redJonathan Gordon2010-05-17
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26110 a1c6a512-1295-4272-9138-f99709370657
* make checkwps accept .rfms files as remote skinsJonathan Gordon2010-05-16
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26082 a1c6a512-1295-4272-9138-f99709370657
* FS#10853 - Skin support in the radio screen! Check CustomWPS for the new tagsJonathan Gordon2010-05-12
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25964 a1c6a512-1295-4272-9138-f99709370657
* Add firmware/include to the include path to fix checkwps.Thomas Martitz2010-05-06
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25851 a1c6a512-1295-4272-9138-f99709370657
* Move read_line() further down so that it can be used in checkwps and remove ↵Thomas Martitz2010-05-03
| | | | | | checkwps' copy if it. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25793 a1c6a512-1295-4272-9138-f99709370657
* some minor changes to checkwps, shouldn't change anythingJonathan Gordon2010-02-24
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24874 a1c6a512-1295-4272-9138-f99709370657
* Make checkwps compile again for the player. If we had proper multifont on ↵Frank Gevaerts2010-02-17
| | | | | | charcell this would never have happened git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24735 a1c6a512-1295-4272-9138-f99709370657
* Initialuse user font table for checkwps. This is normally done from the ↵Frank Gevaerts2010-02-17
| | | | | | settings code, which isn't run in this case git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24734 a1c6a512-1295-4272-9138-f99709370657
* fix checkwpsJonathan Gordon2010-02-16
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24691 a1c6a512-1295-4272-9138-f99709370657
* FS#10984 - multifont! 2 major additions:Jonathan Gordon2010-02-14
| | | | | | | | | | 1) seperate UI font for the remote and main displays 2) allow individual skins to load additional fonts for use in the skin (Uo to 7 extra in this first version) see CustomWPS for info on how to load a font in the skins. Code should always use FONT_UI+screen_number to get the correct user font git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24644 a1c6a512-1295-4272-9138-f99709370657
* fix redsJonathan Gordon2010-01-29
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24367 a1c6a512-1295-4272-9138-f99709370657
* fix red... lets branchJonathan Gordon2010-01-27
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24341 a1c6a512-1295-4272-9138-f99709370657
* Checkwps: use script for getting the targets instead of hardcoded file ↵Maurus Cuelenaere2009-12-29
| | | | | | (fixes checkwps due to target renaming) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24122 a1c6a512-1295-4272-9138-f99709370657
* add sansa clip to checkwps.Dominik Wenger2009-11-29
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23786 a1c6a512-1295-4272-9138-f99709370657
* CheckWPS: set screen to SCREEN_MAIN when not a r{sb,wp}s.Maurus Cuelenaere2009-11-19
| | | | | | This fixes the potential bug of mislabeling an {sb,wp}s as remote while it's not. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23668 a1c6a512-1295-4272-9138-f99709370657
* make checkwps able to check .rsbs files.Dominik Wenger2009-11-19
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23667 a1c6a512-1295-4272-9138-f99709370657
* Forgot to remove wps_data.remove_wps in checkwps too.Thomas Martitz2009-11-04
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23514 a1c6a512-1295-4272-9138-f99709370657
* Fix player yellows and reds. I'm not sure why viewport.c was never compiled ↵Thomas Martitz2009-11-04
| | | | | | for charcell. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23513 a1c6a512-1295-4272-9138-f99709370657
* Reorder a bit in viewport.c so that we don't need stubs for checkwps.Thomas Martitz2009-11-04
| | | | git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23511 a1c6a512-1295-4272-9138-f99709370657
generated by cgit v1.1 at 2026-04-25 13:37:09 +0000